naming a .h file for kernel use only
Konstantin Belousov
kostikbel at gmail.com
Tue Dec 4 21:56:26 UTC 2012
On Tue, Dec 04, 2012 at 03:28:37PM -0500, Rick Macklem wrote:
> Hi,
>
> For my NFSv4.1 client work, I've taken a few definitions out of a
> kernel rpc .c file and put them in a .h file so that they can
> be included in other sys/rpc .c files.
>
> I've currently named the file _krpc.h. I thought I'd check if
> this is a reasonable name before doing the "big commit" of the
> NFSv4.1 stuff to head. (I have a vague notion that a leading "_"
> would indicate "not for public use", but I am not sure?)
>
> Thanks in advance for naming suggestions for this file, rick
I believe that _thing.h is the convention for the headers that are
never directly included by the .c files. It is there to hide some
shared parts of other includes, for consumption by includes.
Why not move the stuff to sys/nfs/krpc.h ? BTW, this file lacks the
include guards.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20121204/acdbef28/attachment.sig>
More information about the freebsd-hackers
mailing list