broken INCLUDE in sys/conf/kern.pre.mk for opensolaris code?

[Alexander Best]

On Wed Feb  2 11, Anonymous wrote:
> Alexander Best <arundel at freebsd.org> writes:
> 
> > On Wed Feb  2 11, Sergey Kandaurov wrote:
> >> On 6 January 2011 04:40, Alexander Best <arundel at freebsd.org> wrote:
> >> > hi there,
> >> >
> >> > while building target buildkernel with 'clang -v' i noticed a lot of these
> >> > lines:
> >> >
> >> > ignoring nonexistent directory "/usr/subversion-src/sys/contrib/opensolaris/compat"
> >> >
> >> > i checked sys/conf/kern.pre.mk and there's a line refering to a non-existing
> >> > directory:
> >> >
> >> > # ... and OpenSolaris
> >> > INCLUDES+= -I$S/contrib/opensolaris/compat
> >> 
> >> Hi, I just removed that path in r218189.
> >
> > thanks a bunch. :)
> >
> > i might do a 'make universe' build at some point with clang -v in order to
> > check, if there are more cases where non-existing include paths exist in the
> > freebsd src.
> 
> -Wmissing-include-dirs (with -Werror) is there to catch such cases.
> Try to add it to CWARNFLAGS and see if universe build passes.
> 
> Note, clang doesn't support it and it's broken in our gcc but there is a
> simple fix, unfortunately, under gplv3.

could you point me to that gcc gplv3 fix?

i don't quite get why clang is missing this feature. -Wmissing-include-dirs was
set to be a noop in r86059 by chris lattner. since clang -v documents missing
include directories, the functionality already exists within llv/clang.

cheers.
alex

-- 
a13x