[PATCH] Fix kenv(1) output in w/respect to new boot loader variables

Devin Teske devin.teske at fisglobal.com
Wed Dec 28 01:49:41 UTC 2011


Garrett Cooper and a few others have requested that I write a patch to fix a
regression w/respect to kenv(1) output in FreeBSD-9.0 and HEAD.

The issue is with the new boot loader menu. It adds many loader variables
including ones that contain ANSI color escapes.

Obviously, these ANSI codes don't play well with serial consoles when kenv(1) is
executed without arguments (reports vary as to what happens, but it's never
pretty).

Attached is a patch to the Forth code that clears-out the menu-associated
variables before invoking the kernel.

The net-effect is that kenv(1) no longer reports menu-related variables.

In essence, kenv(1) output should now appear the same as on RELENG_8 (which
lacks the new boot loader and didn't use any such variables). Thus, restoring
serial console glory.
-- 
Devin

_____________
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.
-------------- next part --------------
--- sys/boot/forth/menu.4th.orig	Sat May 28 01:50:38 2011
+++ sys/boot/forth/menu.4th	Wed Aug 24 23:46:46 2011
@@ -742,11 +742,10 @@
 			else
 				-rot 2drop
 
-				\ disable timeout if less than zero
+				\ boot immediately if less than zero
 				dup 0< if
 					drop
-					0 menu_timeout_enabled !
-					0 ( assigned to menu_timeout below )
+					0 boot
 				then
 			then
 		then
--- sys/boot/forth/menu.4th.8.orig	Sat May 28 01:50:38 2011
+++ sys/boot/forth/menu.4th.8	Wed Aug 24 23:45:57 2011
@@ -96,11 +96,15 @@
 by default) unless a key is pressed.
 If set to
 .Dq Li NO
-(case-insensitive) or
-.Dq Li -1 ,
+(case-insensitive)
 .Ic menu-display
 will wait for user input and never execute
 .Ic menu_timeout_command .
+If set to
+.Dq Li -1 ,
+.Ic menu-display
+will boot immediately, preventing both interruption of the autoboot process and
+escaping to the loader prompt.
 Default is
 .Dq Li 10 .
 See


More information about the freebsd-hackers mailing list