expand_number() for fetch'es -B and -S switches

Alexander Best arundel at freebsd.org
Thu Sep 2 12:23:48 UTC 2010


On Thu Sep  2 10, Dag-Erling Smørgrav wrote:
> Alexander Best <arundel at freebsd.org> writes:
> > so how about something like this? the fetch(1) manual would have to be changed
> > a bit to state that if '-B val' > 1G it silently gets set to 1G.
> 
> 1 GB is ridiculously large.  1 MB should be plenty.

the current maximum buffer limit of fetch(1) actually is around 1G. i think 1M
is not enough, because if people are pulling data over fast lines they'll have
almost constant disk writes. how about 100M then? ;)

on the other hand why have a maximum limit? if people want to have a buffer of
100 gigabyte why shouldn't they? it's their decision actually.

so maybe the maximum buffer check should just be left out and the only
limitation will be that expand_number() can't handle anything that won't fit
into uint64_t.

cheers.
alex

> 
> DES
> -- 
> Dag-Erling Smørgrav - des at des.no

-- 
a13x


More information about the freebsd-hackers mailing list