Remove printf in acpi_tz_sanity()

Andriy Gapon avg at freebsd.org
Mon Nov 22 09:06:20 UTC 2010


on 22/11/2010 01:18 Paul B Mahol said the following:
> On Sun, Nov 21, 2010 at 9:17 PM, Andriy Gapon <avg at freebsd.org> wrote:
>> As is - this is a perfect candidate for a "local only" patch.
>> To be included into the tree - this, most probably, has to be controlled by a
>> tunable/sysctl.
> 
> So solution for useless console spamming is to add useless sysctl.

Are you absolutely sure that they both are/would be useless?
For all uses of acpi_tz_sanity()?
E.g. if some system has never produced those messages in years and then suddenly
starts spewing them out, would that be useless information?

> For -1 values, sane default values should be picked up.

For current temperature too?

> Anyway only _CRT is showing on console, and _PSV & _HOT are both -1 for tz0.

On your system.

> I'm not first one mentioning this and issue is old several years.

OK.

-- 
Andriy Gapon


More information about the freebsd-hackers mailing list