[patch] reminding developers to check for duplicates in
ObsoleteFiles.inc and tools/build/mk/OptionalObsoleteFiles.inc
Anonymous
swell.k at gmail.com
Fri Nov 19 01:57:14 UTC 2010
Anonymous <swell.k at gmail.com> writes:
> Alexander Best <arundel at freebsd.org> writes:
>
>> diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc
>> index e358ed9..106c10e 100644
>> --- a/ObsoleteFiles.inc
>> +++ b/ObsoleteFiles.inc
>> @@ -13,6 +13,12 @@
>> #
>> # The file is partitioned: OLD_FILES first, then OLD_LIBS and OLD_DIRS last.
>> #
>> +# Before you commit changes to this file please check, if any entries in
>> +# tools/build/mk/OptionalObsoleteFiles.inc can be removed. The following
>> +# command was proposed by Dmitry Morozovsky:
>> +# ( grep '+=' /usr/src/ObsoleteFiles.inc | sort -u ; \
>> +# grep '+=' /usr/src/tools/build/mk/OptionalObsoleteFiles.inc | sort -u) | \
>> +# sort | uniq -d
>
> An easier way to check duplicates that understands `.if ${TARGET_ARCH}...'
>
> $ make -V OLD_FILES -V OLD_LIBS -V OLD_DIRS \
> -f Makefile.inc1 check-old \
> | sed 'y/ /\n/' | sort | uniq -d
Nevermind. It's more important to check OptionalObsoleteFiles.inc when
files are re-introduced and thus removed from ObsoleteFiles.inc.
More information about the freebsd-hackers
mailing list