[PATCH] Simplify uart_bus_pci_probe

Garrett Cooper gcooper at FreeBSD.org
Wed Nov 10 08:44:43 UTC 2010


On Tue, Nov 9, 2010 at 10:29 PM, Marcel Moolenaar <xcllnt at mac.com> wrote:
>
> On Nov 6, 2010, at 11:22 AM, Garrett Cooper wrote:
>
>>    Some of the logic could have been simplified in the probe. The
>> proposed patch makes the detection process a tad bit more
>> straightforward.
>>    Comments, review (and maybe a commit :P) are more than welcome :).
>
> The patch is logically wrong for non-ns8250 based UARTs.
> Leave the code as is.

Hi Marcel,
    Is the layout of the pci_ns8250_ids PCI ID table correct then, as
there are a large number of ns16550 chips and other non-ns8250 chips
in the table?
Thanks,
-Garrett


More information about the freebsd-hackers mailing list