C99: Suggestions for style(9)

Rick C. Petty rick-freebsd2008 at kiwi-computer.com
Sat May 2 04:03:30 UTC 2009


On Thu, Apr 30, 2009 at 09:02:26AM -0600, M. Warner Losh wrote:
> 
> This is the biggest one, and I think it may be too soon.  Also, we
> need to be careful on the initialization side of things because we
> currently have a lot of code that looks like:
> 
> 
> 	struct foo *fp;
> 	struct bar *bp;
> 
> 	fp = get_foo();
> 	if (!fp) return;
> 	bp = fp->bp;
> 
> this can't easily be translated to the more natural:
> 
> 	struct foo *fp = get_foo();
> 	struct bar *bp = fp->bp;
> 
> since really you'd want to write:
> 
> 	struct foo *fp = get_foo();
> 	if (!fp) return;
> 	struct bar *bp = fp->bp;
> 
> which isn't legal in 'C'.

I thought we were talking about C99, in which case this is perfectly legal.
I certainly use it all the time in my C99 code.

And I thought this was the point of this discussion, to be able to declare
variables when you first use them.

-- Rick C. Petty


More information about the freebsd-hackers mailing list