can we afford an extra column in iostat?

[Giorgos Keramidas]

On Tue, 14 Jul 2009 14:55:15 -0700, Brian Somers <brian at FreeBSD.org> wrote:
> On Tue, 14 Jul 2009 07:23:12 +0300, Giorgos Keramidas <keramida at freebsd.org> wrote:
>> While converting my laptop's main disk to zfs, I noticed iostat output
>> like this (bits copied from here and there):
>>
>> | keramida at kobe:/home/keramida$ iostat -w3 ad0 da0
>> |       tty             ad0              da0             cpu
>> |  tin tout  KB/t tps  MB/s   KB/t tps  MB/s  us ni sy in id
>> |    5 2119 36.29  56  2.00  54.95   7  0.35   3  0  8  0 89
>> |    0 9478 10.90 290  3.09  57.22  12  0.67  42  0 43  0 15
>> |    012595  1.72 213  0.36  21.36  80  1.66  48  0 48  0  4
>> |    050042  4.56 715  3.19  11.44 164  1.83  29  0 50  1 20
>> |  11529568  7.34 443  3.17  16.97 165  2.74  31  0 53  0 16
>>[.....]
>> | $ ./iostat -w2
>> |       tty             ad0              md0              da0             cpu
>> |  tin  tout  KB/t tps  MB/s   KB/t tps  MB/s   KB/t tps  MB/s  us ni sy in id
>> |    7  2570 32.92  62  1.98   6.46   0  0.00  43.44  10  0.41   4  0  9  0 87
>> |    0 36506  0.99 507  0.49   0.00   0  0.00  20.13 155  3.04  34  0 56  1  9
>> |    0 16695  0.83 226  0.18   0.00   0  0.00  26.16  97  2.48  35  0 56  0  9
>> |    0 24158 10.63 428  4.45   0.00   0  0.00  14.44 137  1.93  32  0 51  0 17
>> | ^C
>>
>> The patch that changes this is quite small:
>
> This should be fixed.  Ironically, the only people that usually
> have problems with fixes like this are people that have seen
> the fields merge and have adjusted some script to understand
> column widths!

Yes, that's a bit unfortunate.  I'm ok with keeping this in 8.X only for
this reason alone, but I would prefer if it was eventually MFCd.

I'll ask re@ if they are ok with committing this now in head.

Thanks :)