Creation of the NO_SSP build knob

[Jeremie Le Hen]

Dag-Erling,

On Thu, Sep 04, 2008 at 09:26:28PM +0200, Dag-Erling Smørgrav wrote:
> Jeremie Le Hen <jeremie at le-hen.org> writes:
> > If SSP belongs to this list, then NO_SSP is an alias for WITHOUT_SSP.
> > But it will still not be possible to use WITH_SSP in src.conf or
> > command-line.
> > [...]
> > Shouldn't we have a knob that overrides whatever the user says, only for
> > internal use in the source tree?  That was my original intent when
> > asking if I could add NO_SSP.
> 
> That's *exactly* what NO_* does.  Just add SSP to that list and replace
> WITHOUT_SSP with NO_SSP wherever it occurs in Makefiles in the tree.

I've just tested it with NO_SSP and I can confirm it doesn't work
despite the explicit comment above stating otherwise.  By the way, the
code is nearly identical between the supported options and the compat
ones, I don't see how it could override the user settings:

186 #
187 # Supported NO_* options (if defined, MK_* will be forced to "no",
188 # regardless of user's setting).
189 #
190 .for var in \
191     INSTALLLIB \
192     MAN \
193     PROFILE \
194     SSP
195 .if defined(NO_${var})
196 WITHOUT_${var}=
197 .endif
198 .endfor
199 
200 #
201 # Compat NO_* options (same as above, except their use is deprecated).
202 #
203 .if !defined(BURN_BRIDGES)
204 .for var in \
205     ACPI \
        [...]
267     WPA_SUPPLICANT_EAPOL
268 .if defined(NO_${var})
269 #.warning NO_${var} is deprecated in favour of WITHOUT_${var}=
270 WITHOUT_${var}=
271 .endif
272 .endfor
273 .endif # !defined(BURN_BRIDGES)


The attached patch implements a behaviour that seems more correct
to me WRT the intent.  What do you think of it?

Thanks!
-- 
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >
-------------- next part --------------
A non-text attachment was scrubbed...
Name: NO_FOO.diff
Type: text/x-diff
Size: 999 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20080905/a1a93504/NO_FOO.bin