investigation of Giant usage in kernel

[Ed Schouten]

Hello,

I took a grep on the kernel source and took a look to Giant usage as
well. I too have a question about locking in uipc_domain.c:

The file has a mutex, dom_mtx, which protects the 'domain list lock',
which could be declared static by the way. The strange thing is that it
isn't used to lock the domain list lock in any way. It is only used to
lock the domain_init_status variable. Wouldn't it be better to rename it
to something better?

The pf_proto_register() routine locks and unlocks Giant. It looks like
s/Giant/dom_mtx/ would be enough to remove the usage of Giant from
uipc_domain.c.

Yours,
-- 
 Ed Schouten <ed at fxq.nl>
 WWW: http://g-rave.nl/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20070304/86eb32d0/attachment.pgp