Latest patch for PPP

Frederic Praca frederic.praca at freebsd-fr.org
Fri Aug 25 17:05:17 UTC 2006


Hello,
in the latest security advisory for PPP, the patch deals with conditions
in a for loop. The correct line is :
for (rlen=0; len >= 2 && p[1] >= 2 && len >= p[1]; len-=p[1], p+=p[1]) {

Couldn't the condition be simpler like :
for (rlen=0; p[1] >= 2 && len >= p[1]; len-=p[1], p+=p[1]){

Or is there a hack I didn't understand ?
In this case, if p[1] is greater or equal than 2, if we ensure that len
>= p[1], we don't have to test that it's greater or equal than 2, isn't
>it ?

Fred


More information about the freebsd-hackers mailing list