Oddity in libufs.

Frank Mayhar frank at exit.com
Sat Sep 24 20:26:35 PDT 2005


I've been using libufs as the I/O mechanism for my (heavy) modification
of sysutils/ffsrecov.  It's working to my needs and now I'm poking at
other bits and pieces to maybe get it suitable for release into the
wild.  I just looked at cgread() to see what it does and noticed that
there seems to be a redundant line:

	.
	.
        if (c >= fs->fs_ncg) {
                return (0);
        }
        ccg = fsbtodb(fs, cgtod(fs, c)) * disk->d_bsize;
        if (bread(disk, fsbtodb(fs, cgtod(fs, c)),
disk->d_cgunion.d_buf,
	.
	.

That assignment up there looks redundant, as ccg is never used.  I
suspect that it's a relic of an old lseek()/read() pair that's long
gone.
-- 
Frank Mayhar frank at exit.com     http://www.exit.com/
Exit Consulting                 http://www.gpsclock.com/
                                http://www.exit.com/blog/frank/


More information about the freebsd-hackers mailing list