libutil properties_read() bug: patch for review

[John Baldwin]

On Wednesday 23 November 2005 07:14 pm, Antony Mawer wrote:
> Hi,
>
> I recently hit upon a bug in sysinstall, getting an "Invalid realloc
> size of 0" error that caused sysinstall to terminate. I eventually
> tracked it down to a bug in the properties_read() function of libutil,
> which occurs only when reading a properties file of 4096 bytes or
> greater. This is because libutil discards its current state when the
> buffer runs out (4096 bytes) and it must refill the buffer, causing the
> properties file (*.inf) to be incorrectly read.
>
> I've made a patch that's attached to the PR I filed, PR 89181, but was
> hoping to get some extra eyes on the patch to make sure that there's
> nothing amiss with the patch:
>
>      http://www.freebsd.org/cgi/query-pr.cgi?pr=89181
>
> Hopefully someone can review this and see about getting it committed for
> 6.1!

I just committed it to HEAD.  It should be MFC'd in time for both 5.5 and 6.1.  
Thanks!

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org