[PATCH2] PPP in -direct mode does not execute any chat scripts

[Maksim Yevmenkin]

Hello Brian,

> Yes, this looks fine, although I think this shows that the -direct
> description is wrong.  Perhaps this is more appropriate:
> 
> -direct
>    This is used for communicating over an already established connection,
>    usually when receiving incoming connections accepted by getty(8).  ppp
>    ignores the ``set device'' line and uses descriptor 0 as the link.  ppp
>    will ignore any configured chat scripts unless the ``force-scripts''
>    option has been enabled.
> 
>    If callback....
> 
> Do you agree with this description ?  If so, I'll go ahead and commit the

yes, this is more accurate description. i missed it.

> changes.  Just to be picky, I'll re-sort the OPT_ variables too :*P

no problem :)

> And thanks for the patches.

thank you for reviewing them :)
max



> On Mon, 03 Feb 2003 14:45:37 -0800, Maksim Yevmenkin wrote:
> 
>>Dear Brian and Hackers,
>>
>>Please find updated proposed version of the patch. As suggested by
>>Warner option has been renamed to 'force-sripts' and now works for
>>both 'direct' and 'dedicated' modes. Also as suggested by Terry the
>>man page has been updated to document side effect of 'direct'.
>>
>>-direct
>>   This is used for receiving incoming connections.  ppp ignores the
>>   ``set device'' line and uses descriptor 0 as the link.  ppp will
>>   never use any configured chat scripts unless ``force-scripts''
>>   option has been enabled.
>>
>>   If callback is configured, ppp will use the ``set device'' infor-
>>   mation when dialing back.
>>
>>-dedicated
>>   This option is designed for machines connected with a dedicated
>>   wire.  ppp will always keep the device open and will never use
>>   any configured chat scripts unless ``force-scripts'' option has
>>   been enabled.
>>
>>force-scripts
>>   Default: Disabled. Forces execution of the configured chat
>>   scripts in direct and dedicated modes.
>>
>>
>>>>Please find attached patch that adds new option to the PPP.
>>>>
>>>>run-scripts-in-direct-mode
>>>>       Default: Disabled. This allows to run chat scripts in
>>>>       direct mode.
>>>>
>>>>did i miss anything? objections? comments? reviews?
>>>
>>>
>>>First comment: run it past Brian Somers <brian at Awfulhak.org>; it's
>>>his baby, and he's the active maintainer.
>>
>>I have sent him e-mail.
>>
>>
>>>Rest of comments:
>>>
>>>Actually, why doesn't "-direct" allow a chat script by default?
>>>The man page doesn't document that as a side-effect of "-direct",
>>>only of "-dedicated", but it's been there since the import.
>>>
>>>Should this really be a "negotiate" section command, rather than
>>>just a command or a "set" command?
>>>
>>>Also, there are only two other commands even have a "-" in them,
>>>and both of them only have one (just seems a little long, compared
>>>to, say, "rsid" or "direct-with-script", or even "force-script").
>>>
>>>Personal preference: don't make it conditional on "-direct", let
>>>it also work with "-dedicated", and call it "force-script" or
>>>something, instead.
>>
>>done
>>
>>
>>>The man page should be updated -- including the undocumented
>>>side-effect of "-direct" disabling scripts).
>>
>>done
>>
>>thanks
>>max
>>
> 
> 
>