curl update to 7.73.0 breaks ABI?

[Kevin Oberman]

Wait! I don't believe that make(8) used #if! It's not C. I think this line
is a comment! Or am I just totally confused?
--
Kevin Oberman, Part time kid herder and retired Network Engineer
E-mail: rkoberman at gmail.com
PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683


On Sun, Oct 18, 2020 at 5:38 PM Kevin Oberman <rkoberman at gmail.com> wrote:

> On Sun, Oct 18, 2020 at 2:05 PM Christian Weisgerber <naddy at mips.inka.de>
> wrote:
>
>> On 2020-10-16, Gary Palmer <gpalmer at freebsd.org> wrote:
>>
>> > Check you have "COOKIES" and "ALTSVC" (I think) checked in the curl
>> > options.  I had cookies disabled for some reason in one of my builds and
>> > it resulted in Curl_get_line not being generated
>>
>> Since 7.73.0, all of lib/curl_get_line.c is behind this:
>>
>> #if !defined(CURL_DISABLE_COOKIES) && !defined(CURL_DISABLE_ALTSVC)
>>
>> --
>> Christian "naddy" Weisgerber                          naddy at mips.inka.de
>>
> Yes, but ALTSVC is set by default (and so is COOKIES) in the port and it
> is still not built. (I had only ALTSVC, not COOKIES.) I have now built with
> COOKIES and it works. Also tried COOKIES without ALTSVC and it also worked.
>
> Not sure why the choice in the presentation of the #if. I'd demornganize
> it for clarity.
> #if defined(CURL_DISABLE_COOKIES) || defined(CURL_DISABLE_ALTSVC)
>
> Still, it should be built and I don't understand why it's not! Does
> Makefile syntax require parens around the full expression? That would
> explain it.
> --
> Kevin Oberman, Part time kid herder and retired Network Engineer
> E-mail: rkoberman at gmail.com
> PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683
>
>