svn commit: r552054 - head/x11/gnome-shell

[Matthias Andree]

Am 11.10.20 um 23:09 schrieb Christoph Moench-Tegeder:
> 
> Hi,
> 
> ## Matthias Andree (mandree at FreeBSD.org):
> 
>> So let's take a spade and dig.  There is
>> work/gnome-shell-3.36.6/subprojects/extensions-tool/meson.build
>>
>> which has
>>
>>> bash_completion = dependency('bash-completion', required: get_option('bash_completion'))
> 
> So it's gnome-shell which needs a dependency on bash-completion.
> We shouldn't (must not?) rely on other ports to pull in our
> dependencies.
> 
>> So unless you are building p11-kit or gnome-control-center with
>> non-default options,
> 
> p11-kit it is (looks like the BASH option there caused me some trouble some
> time ago - don't know what, but it was late and I was angry, according to
> git).
> 
>> Can it hurt to always include the configuration file? We're talking less
>> than 2 kB out of 9 MB flat size.
> 
> When installing gnome, that one file doesn't matter.
> But we should get the dependencies right.

I am not sure if it is a hard dependency. gnome-shell will work without
bash completions for the extension manager, so it's more like a
requisite to cheat meson for gnome-shell, i. e. BUILD_DEPENDS.

Do we want bash-completion also as a run-time dependency?  If so, it's a
more consistent experience at the expense of two more direct requisites
packages (bash-completion, bash).

Any other good reasons to decide about the RUN_DEPENDS, either way?