maintainer-feedback requested: [Bug 250128] www/epiphany: build error (no getrandom(2))

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked freebsd-gnome (Nobody)
<gnome at FreeBSD.org> for maintainer-feedback:
Bug 250128: www/epiphany: build error (no getrandom(2))
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250128



--- Description ---
11.x port builds of www/epiphany fail to compile because of a missing prototype
for getrandom(2).  Of course, the prototype is missing because the actual
syscall is not available on 11.x (as of 11.4).

[41/201] cc -Ilib/libephymisc.so.p -Ilib -I../lib -I. -I.. -I../lib/contrib
-I../lib/history -I../lib/safe-browsing -I/usr/local/include/cairo
-I/usr/local/include -I/usr/local/include/glib-2.0
-I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1
-I/usr/local/include/freetype2 -I/usr/local/include/libdrm
-I/usr/local/include/libpng16 -I/usr/local/include/gdk-pixbuf-2.0
-I/usr/local/include/gio-unix-2.0
-I/usr/local/include/gsettings-desktop-schemas -I/usr/local/include/gtk-3.0
-I/usr/local/include/pango-1.0 -I/usr/local/include/fribidi
-I/usr/local/include/harfbuzz -I/usr/local/include/libepoll-shim
-I/usr/local/include/atk-1.0 -I/usr/local/include/at-spi2-atk/2.0
-I/usr/local/include/dbus-1.0 -I/usr/local/lib/dbus-1.0/include
-I/usr/local/include/at-spi-2.0 -I/usr/local/include/json-glib-1.0
-I/usr/local/include/libdazzle-1.0 -I/usr/local/include/libsecret-1
-I/usr/local/include/libsoup-2.4 -I/usr/local/include/libxml2
-I/usr/local/include/webkitgtk-4.0 -Xclang -fcolor-diagnostics -pipe
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O3
-Werror=declaration-after-statement -Werror=implicit-function-declaration
-Wno-missing-field-initializers -Wno-unused-parameter -O2
-fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing
-isystem /usr/local/include -fPIC -pthread -D_THREAD_SAFE -MD -MQ
lib/libephymisc.so.p/ephy-sync-utils.c.o -MF
lib/libephymisc.so.p/ephy-sync-utils.c.o.d -o
lib/libephymisc.so.p/ephy-sync-utils.c.o -c ../lib/ephy-sync-utils.c
FAILED: lib/libephymisc.so.p/ephy-sync-utils.c.o 
cc -Ilib/libephymisc.so.p -Ilib -I../lib -I. -I.. -I../lib/contrib
-I../lib/history -I../lib/safe-browsing -I/usr/local/include/cairo
-I/usr/local/include -I/usr/local/include/glib-2.0
-I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1
-I/usr/local/include/freetype2 -I/usr/local/include/libdrm
-I/usr/local/include/libpng16 -I/usr/local/include/gdk-pixbuf-2.0
-I/usr/local/include/gio-unix-2.0
-I/usr/local/include/gsettings-desktop-schemas -I/usr/local/include/gtk-3.0
-I/usr/local/include/pango-1.0 -I/usr/local/include/fribidi
-I/usr/local/include/harfbuzz -I/usr/local/include/libepoll-shim
-I/usr/local/include/atk-1.0 -I/usr/local/include/at-spi2-atk/2.0
-I/usr/local/include/dbus-1.0 -I/usr/local/lib/dbus-1.0/include
-I/usr/local/include/at-spi-2.0 -I/usr/local/include/json-glib-1.0
-I/usr/local/include/libdazzle-1.0 -I/usr/local/include/libsecret-1
-I/usr/local/include/libsoup-2.4 -I/usr/local/include/libxml2
-I/usr/local/include/webkitgtk-4.0 -Xclang -fcolor-diagnostics -pipe
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O3
-Werror=declaration-after-statement -Werror=implicit-function-declaration
-Wno-missing-field-initializers -Wno-unused-parameter -O2
-fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing
-isystem /usr/local/include -fPIC -pthread -D_THREAD_SAFE -MD -MQ
lib/libephymisc.so.p/ephy-sync-utils.c.o -MF
lib/libephymisc.so.p/ephy-sync-utils.c.o.d -o
lib/libephymisc.so.p/ephy-sync-utils.c.o -c ../lib/ephy-sync-utils.c
In file included from ../lib/ephy-sync-utils.c:30:
In file included from /usr/local/include/libsoup-2.4/libsoup/soup.h:28:
/usr/local/include/libsoup-2.4/libsoup/soup-date.h:63:10: warning: 'GTimeVal'
is deprecated: Use 'GDateTime' instead [-Wdeprecated-declarations]
				     GTimeVal	    *time);
				     ^
/usr/local/include/glib-2.0/glib/gtypes.h:545:35: note: 'GTimeVal' has been
explicitly marked deprecated here
typedef struct _GTimeVal GTimeVal GLIB_DEPRECATED_TYPE_IN_2_62_FOR(GDateTime);
				  ^
/usr/local/include/glib-2.0/glib/gversionmacros.h:923:49: note: expanded from
macro 'GLIB_DEPRECATED_TYPE_IN_2_62_FOR'
# define GLIB_DEPRECATED_TYPE_IN_2_62_FOR(f)	GLIB_DEPRECATED_TYPE_FOR(f)
						^
/usr/local/include/glib-2.0/glib/gmacros.h:1018:37: note: expanded from macro
'GLIB_DEPRECATED_TYPE_FOR'
#define GLIB_DEPRECATED_TYPE_FOR(f) G_DEPRECATED_FOR(f)
				    ^
/usr/local/include/glib-2.0/glib/gmacros.h:952:44: note: expanded from macro
'G_DEPRECATED_FOR'
#define G_DEPRECATED_FOR(f) __attribute__((__deprecated__("Use '" #f "'
instead")))
					   ^
../lib/ephy-sync-utils.c:192:11: error: implicit declaration of function
'getrandom' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    ret = getrandom (out, num_bytes, 0);
	  ^
1 warning and 1 error generated.
ninja: build stopped: subcommand failed.


See also freebsd package builder failure log:

http://beefy3.nyi.freebsd.org/data/114amd64-quarterly/551243/logs/epiphany-3.38
.0.log


The attached patch implements a workaround for the missing getrandom(2).  When
11.x support ends, this can be removed (or if 11.x gets getrandom(2)).