Mk/Uses/gnome.mk INSTALLS_ICONS broken

[Guido Falsi]

On 01/05/20 21:22, Matthias Andree wrote:
> Am 01.05.20 um 19:49 schrieb Guido Falsi:
>> hi,
>>
>> While testing an update to xfce ports I have got this error in poudriere:
>>
>> =>> Checking for extra files and directories
>> =>> Error: Files or directories removed:
>> share/icons/hicolor/icon-theme.cache
>>
>> And could not find any cause for it.
>>
>> This file should be managed by the INSTALLS_ICONS port variable, which
>> adds post-install and post-deinstall commands.
>>
>> My suspect is the post-deinstall command is not being run properly for
>> some reason causing this error.
>>
>> Could this be correct? How can I verify this?
>>
> I've filed https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246102 for
> this:
> 
> You're hunting the wrong fault, and poudriere reports a genuine bug
> (which is not in your package).

Good catch! I made the wrong guess.

> 
> Read again: the complaint is that the port deinstallation REMOVES (not:
> LEAVES BEHIND) the prior icon-theme.cache.

I understood this, and my claim was that the script regenerating the 
file in post-deinstall was not being ran.

Anyway the offending change was reverted at present, which solves my 
immediate issue, that is properly testing my port update.

-- 
Guido Falsi <madpilot at FreeBSD.org>