[Bug 237567] devel/glib20 - upgrade, improve

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237567

--- Comment #4 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 204019
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=204019
Enable setting and getting of threads' names

Needs to be submitted upstream as configure bits look wrong.

> +#if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__DragonFlyBSD__)

DragonFly only defines __DragonFly__ but not __DragonFlyBSD__. Also, sort
systems alphabetically.

> +#	include <pthread_np.h>

Does not exist on NetBSD.

> +#	if defined(__NetBSD__)
> +#		define pthread_setname_np(t, s) pthread_set_name_np(t, s, NULL)

pthread_set_name_np doesn't exist on NetBSD while pthread_setname_np[1] does
but requires 3 arguments. Additionally, the 3rd argument needs to be explicitly
cast to (void *) to avoid compile error. See
graphics/vkd3d/files/patch-libs_vkd3d_vkd3d__private.h for a simple example.

[1] https://netbsd.gw.com/cgi-bin/man-cgi?pthread_setname_np+3+NetBSD-current

-- 
You are receiving this mail because:
You are the assignee for the bug.