maintainer-feedback requested: [Bug 226920] devel/glib20: pull the latest file monitor fix from upstream

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked gnome at FreeBSD.org for
maintainer-feedback:
Bug 226920: devel/glib20: pull the latest file monitor fix from upstream
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226920



--- Description ---
This is a follow-up of bug 199872.

GLib recently landed a patch contributed by OpenBSD to fix crashes in the
kqueue file monitor backend. Yes, I know we already committed a fix for the
problem in bug 199872, but I saw no change in the frequency of gnome-shell
crashes. The new patch accepted by upstream seems to change it greatly. It
works very well for me and it has been used and tested in OpenBSD ports. I am
unable to trigger any file monitor-related crash in gnome-shell, firefox,
evolution. This new patch will be available in GLib 2.58 (GNOME 3.30). Given
that we are slow on GNOME upgrades, can we replace the old patch committed in
bug 199872 with the new one to fix things more completely and allow broader
testing?

The patch I uploaded here includes 4 commits. The first 3 commits are already
committed to upstream repository, and the last one (written by me) is under
review. Here is the list of referenced bugs in these commits:

https://bugzilla.gnome.org/show_bug.cgi?id=778515
https://bugzilla.gnome.org/show_bug.cgi?id=776147
https://bugzilla.gnome.org/show_bug.cgi?id=739424
https://bugzilla.gnome.org/show_bug.cgi?id=794528