[Bug 220597] deskutils/gucharmap: does not compile

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220597

--- Comment #57 from Ting-Wei Lan <lantw44 at gmail.com> ---
Comment on attachment 194665
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=194665
svn-diff-full-gucharmapt_v2

>Index: Makefile
>===================================================================
>--- Makefile	(revision 473314)
>+++ Makefile	(working copy)
>@@ -2,7 +2,7 @@
> # $FreeBSD$
> 
> PORTNAME=	gucharmap
>-PORTVERSION=	9.0.4
>+PORTVERSION=	10.0.4

The latest gucharmap release is 11.0.1. The version number of gucharmap is
intended to match the version number of Unicode. Since our UCD has version 11,
it will be better to update to gucharmap 11 instead of backporting patches from
11 to 10.

However, gucharmap developers haven't published source tarballs for version 11
because they want to find a way for GitLab to upload tarballs automatically:
https://gitlab.gnome.org/GNOME/gucharmap/issues/3. We may have to switch to
USE_GITLAB in the mean time and this will require autoreconf.

> CATEGORIES=	deskutils gnome
> MASTER_SITES=	GNOME
> DIST_SUBDIR=	gnome3
>@@ -15,12 +15,13 @@
> 
> BUILD_DEPENDS=	itstool:textproc/itstool \
> 		UCD>=0:textproc/UCD
>+LIB_DEPENDS+=	libfreetype.so:print/freetype2

This is fine. The reason gucharmap links directly to freetype2 is that the
upstream developer doesn't want to see color emoji in a character map
application.

> 
> PORTSCOUT=	limitw:1,even
> 
>-USES=		desktop-file-utils gmake gnome libtool localbase \
>+USES=		desktop-file-utils gettext gmake gnome libtool localbase \
> 		pathfix pkgconfig tar:xz
>-USE_GNOME=	cairo gdkpixbuf2 gtk30 intltool introspection:build
>+USE_GNOME=	cairo gdkpixbuf2 gtk30 intltool intlhack introspection:build

Is intlhack still needed? Since using GitLab tarballs will require running
autoreconf, hacks on generated files will not be needed.

> GNU_CONFIGURE=	yes
> CONFIGURE_ARGS=	--with-unicode-data=${LOCALBASE}/share/unicode/ucd/
> USE_LDCONFIG=	yes
>@@ -28,11 +29,14 @@
> 
> GLIB_SCHEMAS=	org.gnome.Charmap.enums.xml \
> 		org.gnome.Charmap.gschema.xml
>+MAKE_ARGS+=	ACLOCAL="${TRUE}" AUTOCONF="${TRUE}" AUTOHEADER="${TRUE}" \
>+		AUTOMAKE="${TRUE}"

Please remove this. This debugging code should not appear in the ports tree.

> 
>-OPTIONS_SUB=	yes
>-OPTIONS_DEFINE=	NLS
>+#OPTIONS_SUB=	yes
>+#OPTIONS_DEFINE=	NLS
> 
>-NLS_USES=	gettext
>-NLS_CONFIGURE_ENABLE=	nls
>+#NLS_USES=	gettext-tools
>+#NLS_CONFIGURE_ENABLE=	nls
>+#NLS_CONFIGURE_OFF=	--disable-nls

If it isn't going to work, can you simply remove them instead of commenting
out?

-- 
You are receiving this mail because:
You are the assignee for the bug.