[Bug 229061] deskutils/gnome-screenshot: Update to 3.22.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229061

--- Comment #4 from Ting-Wei Lan <lantw44 at gmail.com> ---
Comment on attachment 194353
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=194353
patch-gnome-screenshot-3.22.0

>Index: deskutils/gnome-screenshot/Makefile
>===================================================================
>--- deskutils/gnome-screenshot/Makefile	(revision 472678)
>+++ deskutils/gnome-screenshot/Makefile	(working copy)
>@@ -2,7 +2,7 @@
> # $FreeBSD$
> 
> PORTNAME=	gnome-screenshot
>-PORTVERSION=	3.18.0
>+PORTVERSION=	3.22.0

Is there any reason that you want to update it to 3.22.0 instead of the latest
3.26.0 release?

> CATEGORIES=	deskutils gnome
> MASTER_SITES=	GNOME
> DIST_SUBDIR=	gnome3
>@@ -10,17 +10,26 @@
> MAINTAINER=	gnome at FreeBSD.org
> COMMENT=	GNOME 3 utility for making picutures of your screen
> 
>-LIB_DEPENDS=	libcanberra-gtk3.so:audio/libcanberra-gtk3
>+LICENSE=	GPLv2
>+LICENSE_FILE=	${WRKSRC}/COPYING
> 
>+LIB_DEPENDS=	libcanberra-gtk3.so:audio/libcanberra-gtk3 \
>+		libcanberra.so:audio/libcanberra
>+

OK, I found the same change is also committed to the FreeBSD GNOME development
repository.

> CONFLICTS=	gnome-utils-2.[0-9]*
> PORTSCOUT=	limitw:1,even
> 
>-USES=		gettext gmake gnome pathfix pkgconfig tar:xz
>-USE_GNOME=	gtk30 intlhack
>+USES=		gettext-tools gmake gnome localbase pathfix pkgconfig tar:xz
>+USE_GNOME=	cairo gdkpixbuf2 gtk30 intlhack
>+USE_XORG=	x11 xext
> GNU_CONFIGURE=	yes
>-CPPFLAGS+=	-I${LOCALBASE}/include
>-LIBS+=		-L${LOCALBASE}/lib
> 
> GLIB_SCHEMAS=	org.gnome.gnome-screenshot.gschema.xml
> 
>+OPTIONS_DEFINE=	NLS
>+OPTIONS_SUB=	yes
>+
>+NLS_USES=		gettext-runtime
>+NLS_CONFIGURE_OFF=	--disable-nls
>+
> .include <bsd.port.mk>

Adding NLS option looks fine, but I think many GNOME ports don't do it. Is
there a use case other than saving disk space?

>Index: deskutils/gnome-screenshot/distinfo
>===================================================================
>--- deskutils/gnome-screenshot/distinfo	(revision 472678)
>+++ deskutils/gnome-screenshot/distinfo	(working copy)
>@@ -1,2 +1,3 @@
>-SHA256 (gnome3/gnome-screenshot-3.18.0.tar.xz) = eba64dbf4acf0ab8222fec549d0a4f2dd7dbd51c255e7978dedf1f5c06a98841
>-SIZE (gnome3/gnome-screenshot-3.18.0.tar.xz) = 281752
>+TIMESTAMP = 1529110023
>+SHA256 (gnome3/gnome-screenshot-3.22.0.tar.xz) = 8a05f14b3c7c6cb42f9848ad0332034c7fe5c34a69742910203588fd60b00230
>+SIZE (gnome3/gnome-screenshot-3.22.0.tar.xz) = 258888
>Index: deskutils/gnome-screenshot/files/patch-src_screenshot-utils.c
>===================================================================
>--- deskutils/gnome-screenshot/files/patch-src_screenshot-utils.c	(nonexistent)
>+++ deskutils/gnome-screenshot/files/patch-src_screenshot-utils.c	(working copy)
>@@ -0,0 +1,20 @@
>+--- src/screenshot-utils.c.orig	2016-07-11 14:55:18 UTC
>++++ src/screenshot-utils.c
>+@@ -630,6 +630,9 @@ screenshot_get_pixbuf (GdkRectangle *rec
>+                                      filename);
>+     }
>+ 
>++  if (!g_strcmp0 (g_getenv ("XDG_CURRENT_DESKTOP"), "GNOME"))
>++      screenshot = screenshot_fallback_get_pixbuf(rectangle);

Why is it needed? Does it mean the builtin screenshot function of GNOME Shell
is broken on your system?

>++  else {
>+   connection = g_application_get_dbus_connection (g_application_get_default ());
>+   g_dbus_connection_call_sync (connection,
>+                                "org.gnome.Shell.Screenshot",
>+@@ -659,6 +662,7 @@ screenshot_get_pixbuf (GdkRectangle *rec
>+ 
>+       screenshot = screenshot_fallback_get_pixbuf (rectangle);
>+     }
>++  }
>+ 
>+   g_free (path);
>+   g_free (tmpname);
>
>Property changes on: deskutils/gnome-screenshot/files/patch-src_screenshot-utils.c
>___________________________________________________________________
>Added: fbsd:nokeywords
>## -0,0 +1 ##
>+yes
>\ No newline at end of property
>Added: svn:eol-style
>## -0,0 +1 ##
>+native
>\ No newline at end of property
>Added: svn:mime-type
>## -0,0 +1 ##
>+text/plain
>\ No newline at end of property
>Index: deskutils/gnome-screenshot/pkg-descr
>===================================================================
>--- deskutils/gnome-screenshot/pkg-descr	(revision 472678)
>+++ deskutils/gnome-screenshot/pkg-descr	(working copy)
>@@ -1 +1,4 @@
>-GNOME 3.0 utility for taking pictures of your screen.
>+GNOME Screenshot is a small utility that takes a screenshot of the whole
>+desktop; the currently focused window; or an area of the screen.
>+
>+WWW: https://github.com/GNOME/gnome-screenshot

This link is not correct. GNOME uses its own GitLab instance for development.
GitHub is just a read-only mirror.
I think you should put https://gitlab.gnome.org/GNOME/gnome-screenshot here.

-- 
You are receiving this mail because:
You are the assignee for the bug.