[Bug 219161] www/webkit2-gtk3: 2.14.6 fails to build depending on $PATH

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219161

--- Comment #7 from John Hein <z7dr6ut7gs at snkmail.com> ---
Created attachment 182671
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=182671&action=edit
[patch] explicitly point to base binutils tools if not using ports binutils

I added an -B/usr/bin to Carlos' patch.  If we are explicitly setting the path
for certain base tools (/usr/bin/ar, etc.), we should explicitly tell clang++40
to look in /usr/bin at link time instead of relying on /usr/bin being in your
path before /usr/local/bin.

It turns out that the newer ld from the binutils port will probably work fine
with .a files generated by the current /usr/bin/ar & /usr/bin/ranlib.  But it's
better to explicitly point to /usr/bin/ld to match the use of base ar & ranlib,
IMO.

By the way, something in the cmake code is causing the detection of ar, ranlib,
etc., tools based on the CMAKE_CXX_COMPILER path.  If CMAKE_CXX_COMPILER is
/usr/local/bin/clang++40, it finds ar, ranlib, etc., in /usr/local/bin (if
binutils port is installed).  If CMAKE_CXX_COMPILER is /usr/bin/c++, cmake
finds ar, ranlib, etc., in /usr/bin.

Trying to follow the cmake logic to see where the determination which tool to
use is difficult (at least for me).  I'm no cmake guru.  So there may be
another way to "hint" cmake where to look for the tools.  But this patch works
well enough, I think.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.