[Bug 211201] print/freetype2: update to 2.7, add V40 code

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211201

--- Comment #63 from Jan Beich (mail not working) <jbeich at FreeBSD.org> ---
(In reply to lightside from comment #56)
> (In reply to comment #55)
>> Can we avoid the complexity in this case?
>> It'd even be 4 lines shorter.
> What you proposed is the same complexity, but with static variant, which may
> require to extend number of checks (2^n - 1, where n is 2 currently) for
> options, in case of more modes.

It'd be better to ask upstream as gnome@ (or kwm@) are probably just as
clueless whether there'd would be more options in future. I don't expect that
due to increased maintenance compared to always compiling in the code. For one,
v40 only exist because ...

   If someone finds ways to make older fonts render better without
   introducing lists or overly complex hacks, I'm interested.

https://www.freetype.org/freetype2/docs/subpixel-hinting.html

>> - Don't use SED when modifying in-place
>> - Make backup suffix a bit more verbose than just one confusing letter
> This is not justified.
> The reason to use ${SED} instead of ${REINPLACE_CMD} with different backup
> extension (i.e. -i '.d.bak')  is following:
> -8<--
> % make -C /usr/ports/print/freetype -V REINPLACE_CMD
> /usr/bin/sed -i.bak
> % make -C /usr/ports/print/freetype -V SED
> /usr/bin/sed
> -->8-

I'm arguing about semantic meaning of editing file(s) in-place: REINPLACE_CMD
carries it while SED does not. Adjusting (or removing) backup suffix is more
popular via REINPLACE_CMD:

  $ cd /usr/ports
  $ git grep 'SED.* -i ' | wc -l
       125
  $ git grep 'REINPLACE_CMD.* -i ' | wc -l
       263

Also, keeping '.bak' component the last avoids confusion with '.d' or '.debug'
being a non-backed up file extension.

> (In reply to comment #55)
>> - Use "-e" option to split commands rather than ";" to avoid tracking open quotes
> This is just your preference, in my opinion. It also works with ";".

";" requires tracking open quotes whenever a new substitution is added instead
of being just one "+" line in a diff. "-e" is *probably* more popular in ports
but I'm biased. Actually measuring usage may require a careful regexp to parse
newlines, (single/double) quotes, "s" command syntax.

-- 
You are receiving this mail because:
You are on the CC list for the bug.