[Bug 211684] audio/pulseaudio: Respect hw.snd.default_unit

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Nov 9 20:58:35 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211684

lightside <lightside at gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176143|maintainer-approval?(gnome@ |
              Flags|FreeBSD.org)                |
 Attachment #176143|0                           |1
        is obsolete|                            |
 Attachment #176830|                            |maintainer-approval?(gnome@
              Flags|                            |FreeBSD.org)

--- Comment #18 from lightside <lightside at gmx.com> ---
Created attachment 176830
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=176830&action=edit
Proposed patch (since 424621 revision)

(In reply to comment #17)
> Default device parsing fails with hw.snd.verbose > 0.
Not sure what you meant about "parsing fails". The parsing algorithm was
developed in such a way, that recognizes concrete format of /dev/sndstat output
(e.g. the "default" word at the end of line). If format of output is different,
then further algorithm does nothing (as it was for "hw.snd.verbose > 0" case).
Theoretically possible to break parsing algorithm (e.g. with custom
/dev/sndstat output), I guess. But this is a possible drawback of such
approach.

Probably, you meant, that "the parsing algorithm doesn't work for
hw.snd.verbose > 0 case". Looks like, sysctl hw.snd.verbose may change format
of /dev/sndstat output. I extended parsing algorithm for "hw.snd.verbose > 0"
case.

Thanks for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the freebsd-gnome mailing list