[Bug 211201] print/freetype2: update to 2.6.5, replace LCD_FILTERING with V40 code

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211201

--- Comment #16 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 172887
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=172887
Proposed patch (since 412348 revision)

> +LICENSE_FILE_FREETYPE2=	${WRKSRC}/docs/LICENSE.TXT

The file documents how to use (included) licenses but isn't an actual license.
Try running

  $ LICENSES_ASK=1 make clean patch

When a user selects USE_FREETYPE2 what license terms she accepts? If the answer
is in either docs/GPLv2.TXT or docs/FTL.TXT then it's invalid because those are
already claimed by other licenses.

> +LICENSE_FILE_GPLv2=	${WRKSRC}/docs/GPLv2.TXT

GNU project says

  Please note that GPLv3 is not compatible with GPLv2 by
  itself. However, most software released under GPLv2 allows you to
  use the terms of later versions of the GPL as well. When this is the
  case, you can use the code under GPLv3 to make the desired
  combination. To learn more about compatibility between GNU licenses,
  please see our FAQ.

which is the case here (in docs/LICENSE.TXT)

  - The GNU General Public License version 2, found in  `GPLv2.TXT' (any
    later version can be used  also), for programs which already use the
    GPL.  Note  that the  FTL is  incompatible  with  GPLv2 due  to  its
    advertisement clause.

 ports r405873 added "or any later version" types in order to track such
compatibility.

> +OPTIONS_RADIO=		SUBPIXEL_HINTING
> +OPTIONS_RADIO_SUBPIXEL_HINTING=	V38 V40 BOTH

BOTH option may confuse users but can be eliminated via OPTIONS_GROUP at the
cost of losing option helpers for the conditional.

(In reply to lightside from comment #13)
> In case of GPLv2+, it shows the stub, even if LICENSE_FILE_GPLv2+
> (or LICENSE_FILE_GPLv2) defined (in first case, this is addition
> (+=), right?).

amdmi3@ documented the issue in Mk/bsd.licenses.db.mk as

  # Note that though plus is allowed in a variable (and this license) name it
  # needs an extra space before following equals sign for them not to be parsed
  # as a single += operator

with comment 3 as another example.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.