[Bug 211684] audio/pulseaudio: Respect hw.snd.default_unit

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211684

--- Comment #2 from Tobias Kortkamp <t at tobik.me> ---
(In reply to lightside from comment #1)
Hi Lightside,

thanks for looking into it.

Your patch works but has a big flaw in that it only creates a
sink for the default device.  The other devices are skipped.
That's a big divergence from the current behavior.  Users might
want to switch streams to a specific sink (OSS device).

Given that it only creates one sink, there is no point in even
reading /dev/sndstat anymore as we could just create one sink for
/dev/dsp.

Since you went to the trouble of recreating the patch in a
different way, I'd like to know why you dismissed my approach?
What's wrong with it in your eyes?  I ask because I'm willing to
do the work on this one, even for PulseAudio 9.0, if someone tells
me what to change and explains why.

Let me summarize my POV of what the requirements of this are:

1. PulseAudio does not respect hw.snd.default_unit and does not set
   its default sink to the sink corresponding to the default device.

2. PulseAudio uses the first sink as the default sink by default,
   so one way to force PulseAudio to use it, is by adding the default
   device first.

3. That's what I did with my patch, but since /dev/dsp will appear
   again in /dev/sndstat with a different name we get a duplicated
   device in the sink list.  If we don't want that, we need to add the
   default device first, then all the others.  Your patch is half of
   that solution.  There needs to be e.g. a second loop over /dev/sndstat
   after the first one.

4. Not adding /dev/dsp to the sink list means changes to
   hw.snd.default_unit are not picked up by the PulseAudio daemon
   anymore without restarting it.

5. But we also absolutely want to have corresponding sinks for ALL
   other OSS devices in PulseAudio to retain the current flexibility.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.