Upgrade of x11-fm/nautilus fails

[Koop Mast]

On 17-3-2013 4:52, Kevin Oberman wrote:
> On Thu, Mar 14, 2013 at 10:22 PM, Kevin Oberman <rkoberman at gmail.com> wrote:
>
>> I am unable to build nautilus-2.32.2.1_3. I previously build 2.32.2.1_2
>> without issues, but I get the following error:
>>
>> gmake[4]: Entering directory
>> `/usr/ports/x11-fm/nautilus/work/nautilus-2.32.2.1/src'
>>    CC     nautilus-application.o
>> In file included from /usr/local/include/unique-1.0/unique/uniqueapp.h:26,
>>                   from /usr/local/include/unique-1.0/unique/unique.h:24,
>>                   from nautilus-application.h:32,
>>                   from nautilus-application.c:29:
>> /usr/local/include/unique-1.0/unique/uniquemessage.h:51: error: expected
>> '=', ',', ';', 'asm' or '__attribute__' before 'guchar'
>> /usr/local/include/unique-1.0/unique/uniquemessage.h:66: error: expected
>> '=', ',', ';', 'asm' or '__attribute__' before 'gchar'
>> In file included from /usr/local/include/unique-1.0/unique/unique.h:25,
>>                   from nautilus-application.h:32,
>>                   from nautilus-application.c:29:
>> /usr/local/include/unique-1.0/unique/uniquebackend.h:97: error: expected
>> '=', ',', ';', 'asm' or '__attribute__' before 'gchar'
>> /usr/local/include/unique-1.0/unique/uniquebackend.h:100: error: expected
>> '=', ',', ';', 'asm' or '__attribute__' before 'gchar'
>> nautilus-application.c: In function 'message_received_cb':
>> nautilus-application.c:843: warning: passing argument 2 of 'open_windows'
>> makes pointer from integer without a cast
>> gmake[4]: *** [nautilus-application.o] Error 1
>> gmake[4]: Leaving directory
>> `/usr/ports/x11-fm/nautilus/work/nautilus-2.32.2.1/src'
>> gmake[3]: *** [all-recursive] Error 1
>> gmake[3]: Leaving directory
>> `/usr/ports/x11-fm/nautilus/work/nautilus-2.32.2.1/src'
>> gmake[2]: *** [all] Error 2
>> gmake[2]: Leaving directory
>> `/usr/ports/x11-fm/nautilus/work/nautilus-2.32.2.1/src'
>> gmake[1]: *** [all-recursive] Error 1
>> gmake[1]: Leaving directory
>> `/usr/ports/x11-fm/nautilus/work/nautilus-2.32.2.1'
>> gmake: *** [all] Error 2
>> *** [do-build] Error code 1
>>
>> This happens on multiple systems running 9.1-Stable, both i386 and amd64.
>> Tried with both base gcc and 4.6 with the same results. I have not tried
>> with clang. All systems have unique-1.1.6_3 installed.
>>
>> Any ideas?
>> --
>> R. Kevin Oberman, Network Engineer
>> E-mail: rkoberman at gmail.com
>>
> Found the problem. Koop updated unique to replace all instances of
> 'G_CONST_RETURN' to 'const'. Somehow, on multiple systems, I had the
> replacement only in the file uniqueapp.c. I'm unsure how this could happen
> as the change was a single commit of Makefile. I had assumed that it was
> two separate commits and that there was no PORTREVISION bump, but now I'm
> just confused. I still  believe that this probably should have had a
> PORTREVISION bump, but I'm not sure any longer.
>
> I had uniqueapp.c and uniquebackend.c that had 'G_CONST_RETURN' replaced by
> 'const' but both uniquebackend.h and uniquemessage.h still has
> 'G_CONST_RETURN. I'm totally confused about this..
>
> In any case, the problem appears to have been 'unique' to my systems.

My bad. I did a portrevision bump just in case there are more cases out 
there like this.

-Koop