charset.alias

Alex Dupre ale at FreeBSD.org
Fri Oct 5 18:26:21 UTC 2012


Greg Larkin ha scritto:
> I included the charset.alias data generated by the devel/patch build
> itself (config.charset script, IIRC), and I followed the spirit of the
> existing code in the application in deciding to embed it within an
> #if/#endif block.

Yep, but such scripts/code are taken from libiconv 'as-is': 
http://git.savannah.gnu.org/cgit/libiconv.git/tree/libcharset/lib

We have patched libiconv in the tree to create the correct 
charset.alias, so it makes sense to use it (since it doesn't require 
code modification in other applications) instead of patching 
localcharset.c in every program that bundle it.

> Since I am no expert on charsets, libiconv or gettext, please feel
> free to replace my fix with your patch, if that's a better long-term
> solution.

Let's hear other opinions.

-- 
Alex Dupre


More information about the freebsd-gnome mailing list