[PATCH] textproc/libxslt: remove USE_GETTEXT=yes

[Sunpoet Po-Chuan Hsieh]

>Submitter-Id:	current-users
>Originator:	Sunpoet Po-Chuan Hsieh
>Organization:	SUNPOET.net
>Confidential:	no 
>Synopsis:	[PATCH] textproc/libxslt: remove USE_GETTEXT=yes
>Severity:	non-critical
>Priority:	low
>Category:	ports 
>Class:		change-request
>Release:	FreeBSD 8.1-PRERELEASE amd64
>Environment:
System: FreeBSD bonjour.sunpoet.net 8.1-PRERELEASE FreeBSD 8.1-PRERELEASE #0: Wed May 19 00:13:00 CST 2010
>Description:

gettext dependency was added to libxslt if CRYPTO option is on (by default).
However, libxslt does not link against gettext library if libgpg-error was built without NLS support (WITHOUT_NLS option).
Thus I think USE_GETTEXT should be removed.

Dependency tree:
libxslt ---> libgcrypt ---> libgpg-error ---> gettext
     depends on                      (conditional)

Port maintainer (gnome at FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99

>How-To-Repeat:

% cd /usr/ports/security/libgpg-error
% make WITHOUT_NLS=yes install
% cd /usr/ports/textproc/libxslt
% make -V WITH_CRYPTO
true
% make install
% ldd /usr/local/lib/libexslt.so.8 /usr/local/lib/libxslt.so.2
/usr/local/lib/libexslt.so.8:
        libgcrypt.so.16 => /usr/local/lib/libgcrypt.so.16 (0x800c00000)
        libgpg-error.so.0 => /usr/local/lib/libgpg-error.so.0 (0x800d71000)
        libxslt.so.2 => /usr/local/lib/libxslt.so.2 (0x800e74000)
        libxml2.so.5 => /usr/local/lib/libxml2.so.5 (0x800faa000)
        libz.so.5 => /lib/libz.so.5 (0x8011e8000)
        libiconv.so.3 => /usr/local/lib/libiconv.so.3 (0x8012fc000)
        libm.so.5 => /lib/libm.so.5 (0x8014fe000)
        libc.so.7 => /lib/libc.so.7 (0x800645000)
/usr/local/lib/libxslt.so.2:
        libxml2.so.5 => /usr/local/lib/libxml2.so.5 (0x800c00000)
        libz.so.5 => /lib/libz.so.5 (0x800e3e000)
        libiconv.so.3 => /usr/local/lib/libiconv.so.3 (0x800f52000)
        libm.so.5 => /lib/libm.so.5 (0x801154000)
        libc.so.7 => /lib/libc.so.7 (0x800645000)

>Fix:

--- libxslt-1.1.26_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/textproc/libxslt/Makefile /usr/ports/sunpoet/libxslt/Makefile
--- /usr/ports/textproc/libxslt/Makefile	2010-06-03 09:02:11.000000000 +0800
+++ /usr/ports/sunpoet/libxslt/Makefile	2010-06-05 19:29:33.000000000 +0800
@@ -46,7 +46,6 @@
 
 .if defined(WITH_CRYPTO)
 LIB_DEPENDS+=	gcrypt.16:${PORTSDIR}/security/libgcrypt
-USE_GETTEXT=	yes
 .else
 CONFIGURE_ARGS+=--without-crypto
 .endif
--- libxslt-1.1.26_1.patch ends here ---