ports/146885: [patch] fix make package for x11-toolkits/gtk20 when WITHOUT_CUPS set

[Garrett Cooper]

On Mon, May 31, 2010 at 8:22 PM, Joe Marcus Clarke <marcus at freebsd.org> wrote:
> On 5/31/10 10:47 PM, Garrett Cooper wrote:
>> On Mon, May 31, 2010 at 5:22 PM, Joe Marcus Clarke <marcus at freebsd.org> wrote:
>>> On 5/31/10 7:45 PM, Garrett Cooper wrote:
>>>> On Mon, May 31, 2010 at 2:20 PM,  <marcus at freebsd.org> wrote:
>>>>> Synopsis: [patch] fix make package for x11-toolkits/gtk20 when WITHOUT_CUPS set
>>>>>
>>>>> State-Changed-From-To: open->feedback
>>>>> State-Changed-By: marcus
>>>>> State-Changed-When: Mon May 31 21:17:12 UTC 2010
>>>>> State-Changed-Why:
>>>>> I don't see the bug.  First, we _should_ be checking for libcups in ${LOCALBASE}
>>>>> and not ${PREFIX}.  The other changes just look to be aesthetic.
>>>>
>>>>     They're not. := is acceptable for deferred make variables... not
>>>> for the plist stuff (was this ever functional?).
>>>
>>> Yes, that's functional and perfectly allowed.  The ":=" in this notation
>>> is just acting as a label (the label being "CUPS:").  There are other
>>> ports which use this same notation.
>>
>> Why does my version pass then when cups isn't installed :)?
>> Thanks,
>> -Garrett
>>
>>
>
> I don't see a bug, and this code hasn't changed in sometime.  To be
> clear you do NOT have /usr/local/lib/libcups.so installed?  Exactly what
> CUPS-related macros do you have defined?

I haven't willingly defined any CUPS related macros. The only ones
that have been defined in the past (because they were the defaults and
I hadn't cleaned them out until as of late) were the CUPS knobs in
print/ghostscript8-nox11. There also appear to be a bunch of implicit
dependencies on cups in xfce4 dependencies for some odd reason even
though I purposely have USE_PRINT unchecked. I pkg_delete'd
cups-client and cups-image today and I'm yanking out the rest of the
bits by hand while I'm upgrading xfce4 today.

Running make package doesn't yield the same problem it did before, but
I purposely yanked all of the cups packages.

Looking for the files in ${LOCALBASE}, not ${PREFIX} seems
non-portable if ports wants to make an attempt at the case where
${PREFIX} != ${LOCALBASE} though.

Thanks,
-Garrett