ports/146885: [patch] fix make package for x11-toolkits/gtk20 when WITHOUT_CUPS set

Joe Marcus Clarke marcus at freebsd.org
Tue Jun 1 00:22:55 UTC 2010


On 5/31/10 7:45 PM, Garrett Cooper wrote:
> On Mon, May 31, 2010 at 2:20 PM,  <marcus at freebsd.org> wrote:
>> Synopsis: [patch] fix make package for x11-toolkits/gtk20 when WITHOUT_CUPS set
>>
>> State-Changed-From-To: open->feedback
>> State-Changed-By: marcus
>> State-Changed-When: Mon May 31 21:17:12 UTC 2010
>> State-Changed-Why:
>> I don't see the bug.  First, we _should_ be checking for libcups in ${LOCALBASE}
>> and not ${PREFIX}.  The other changes just look to be aesthetic.
> 
>     They're not. := is acceptable for deferred make variables... not
> for the plist stuff (was this ever functional?).

Yes, that's functional and perfectly allowed.  The ":=" in this notation
is just acting as a label (the label being "CUPS:").  There are other
ports which use this same notation.

Joe

-- 
Joe Marcus Clarke
FreeBSD GNOME Team	::	gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome


More information about the freebsd-gnome mailing list