hal truncating block.device on freebsd-8.0rc1

[J.R. Oldroyd]

On Fri, 23 Oct 2009 01:44:32 -0400, Joe Marcus Clarke <marcus at marcuscom.com> wrote:
>
> On Fri, 2009-10-23 at 01:37 -0400, J.R. Oldroyd wrote:
> > On Fri, 23 Oct 2009 00:02:03 -0400, Joe Marcus Clarke <marcus at marcuscom.com> wrote:
> > > 
> > > Hal doesn't support volumes with spaces in their names.  This is
> > > documented in the FreeBSD HAL FAQ at
> > > http://www.freebsd.org/gnome/docs/halfaq.html .  Patches to add support
> > > for this are very welcome.
> > > 
> > > Joe
> > > 
> > 
> > That doc, and some googling which found two year old email from you,
> > show that this is apparently a long-standing problem with geom/glabel.
> > 
> > Any pointers on where the defective code might lie?
> 
> hald/freebsd/hf-storage.c.  The fix would be to process
> kern.geom.confxml instead of kern.geom.conftxt.
> 
> Joe
> 

I have a simple patch to the conftxt parser that looks for LABEL
lines and appends fields until the "i" field is in the right
place.  This fixes things for this camera.

I have no other devices at hand to test to see if anything broke,
however.

The replacement files/patch-hald_hf-storage.c with the additional
patch is here:
    http://opal.com/jr/hal/patch-hald_hf-storage.c

By the way, the patch file should probably be renamed to
files/patch-hald_freebsd_hf-storage.c for consistency with the
other patch files there.

	-jr