ports-mgmt/bpm

Joseph S. Atkinson jsatkinson at embarqmail.com
Sat Aug 9 14:52:24 UTC 2008


Pav,

You asked me to submit a fix for ports-mgmt/bpm since I discovered it 
was recently broken on 8. Here it is.

I can't figure out what it needs to include bsd.sys.mk for, and it seems 
build/install/run fine without it. Maybe it's something historical and 
now provided by ports' Mk universe.

Anyway, the patch just comments out that entire .if block and skips the 
include.

I cc'ed the author/maintainer since it should have his notice and/or 
input before going in. Also, he may be willing to shed some insight on 
why bsd.sys.mk was included (and only for FreeBSD) in the first place.

In looking at files/patch-src::refresh.c, there is a big block comparing 
the __FreeBSD_version number. This requires periodic updates to as 
FreeBSD progresses through major version numbers. If we devise a way to 
pass ${INDEXFILE} (see Mk/bsd.port.mk) directly to the build, the port 
should keep working until something truly fundamental breaks.

Additionally, I cc'ed gnome@ because this port is included in the 
x11/gnome2-power-tools meta and figured the above might be of interest 
to them.
-------------- next part --------------
--- mk/sk.global.mk.orig	2008-08-09 08:27:47.000000000 -0400
+++ mk/sk.global.mk	2008-08-09 08:29:12.000000000 -0400
@@ -51,10 +51,6 @@
 .PATH: ${.CURDIR}/${BASE_DIR}/mk/src
 PICFLAGS = -fpic
 
-.if ${OSTYPE} == "FreeBSD"
-.include    <bsd.sys.mk>
-.endif
-
 CXX?= c++
 
 AR?= ar


More information about the freebsd-gnome mailing list