HAL on FreeBSD 5.5 redux

[Michael Nottebrock]

While regression testing a few new patches for KDE's media kioslave, I found 
out that the FreeBSD 5.5 fix for cdroms as committed to ports doesn't 
actually work - because of this code:

/* Better to assert here than panic the machine. */
/* XXX Should this be a conditional?  How likely is this? */
assert(cdrom->channel >= 0);
assert(cdrom->device >= 0 && cdrom->device < 2);

I don't know what this is supposed to do (avoid using both atapicam & atapicd 
devices?), but it does prevent detection of any cdrom volumes here when 
atapicam is disabled. I have two cd/dvd writers (acd0 and acd1) in this 
machine. 

I didn't notice this earlier because I skipped hal-0.5.8-20061224, but I did 
go back to it now and can confirm that that version doesn't work either 
unless those lines are removed.


Cheers,
-- 
   ,_,   | Michael Nottebrock               | lofi at freebsd.org
 (/^ ^\) | FreeBSD - The Power to Serve     | http://www.freebsd.org
   \u/   | K Desktop Environment on FreeBSD | http://freebsd.kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20070209/6a3a4266/attachment.pgp