Patch Attribution

Warner Losh imp at bsdimp.com
Sat Jan 9 17:54:41 UTC 2021


On Sat, Jan 9, 2021 at 10:52 AM Kyle Evans <kevans at freebsd.org> wrote:

> Hello!
>
> I haven't (that I recall) seen any particular guidance one way or the
> other, but what's the general feeling on "Submitted by" for patches
> that come in via Bugzilla without commit metadata vs. committing
> locally with --author="Name <email>"?
>
> I did this with d36b5db and didn't receive any complaints, but I'm
> curious if we should be more actively promoting setting the author
> correctly whether the patch came in with it or not. I noted that
> Warner's meta doc[0] lists "Submitted-by" which is where my
> uncertainty comes from.
>

My document should be updated. I think what you did is fine, and we should
document it as best practice.

Warner


More information about the freebsd-git mailing list