maintainer-approval requested: [Bug 242523] security/nss 3.48 doesn't build on PowerPC : [Attachment 210548] v2

[bugzilla-noreply at freebsd.org]

Piotr Kubaj <pkubaj at FreeBSD.org> has asked freebsd-gecko mailing list
<gecko at FreeBSD.org> for maintainer-approval:
Bug 242523: security/nss 3.48 doesn't build on PowerPC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242523

Attachment 210548: v2
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=210548&action=edit



--- Comment #17 from Piotr Kubaj <pkubaj at FreeBSD.org> ---
Created attachment 210548
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=210548&action=edit
v2

- Fix build without AltiVec, Crypto and VSX by moving altivec-types.h include
to USE_PPC_CRYPTO's ifdef -this header is not necessary without USE_PPC_CRYPTO
enabled,
- Enable USE_PPC_CRYPTO on BE as well if VSX and Crypto are supported,
- Add non-default VSX option for adding -mvsx -mcrypto to set USE_PPC_CRYPTO,
- since we don't need new GCC now, don't set USES=compiler:c11 by default.

This fixes powerpc and powerpc64 build without AltiVec, Crypto and VSX and
makes it possible to use USE_PPC_CRYPTO which should accelerate things.

make test output without this patch:
Passed: 	    14415
Failed: 	    58
Failed with core:   0
ASan failures:	    0
Unknown status:     52
TinderboxPrint:Unknown: 52

And with:
Passed: 	    14471
Failed: 	    2
Failed with core:   0
ASan failures:	    0
Unknown status:     52
TinderboxPrint:Unknown: 52