[Bug 240686] security/nss: regressions tests require bash

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240686

Jan Beich <jbeich at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207626|                            |maintainer-approval+
              Flags|                            |

--- Comment #1 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 207626
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=207626
Run regression tests with bash

Looks OK but see comments below. Bash'isms appear to have been introduced
recently. Kinda sad as FreeBSD sh is blazingly fast while tests take a lot of
time due to lack of parallelism.

> +TEST_DEPENDS=	bash:shells/bash

For "make test" to install the dependency convert "check regression-test test"
(multi-name target) to "do-test". When tinderbox was in use by the package
cluster (pointyhat at the time) "regression-test" was used and TEST_DEPENDS was
handled by tinderbox itself rather than the ports framework.

> +			${LOCALBASE}/bin/bash ./all.sh

Consistently use either "bash" or "${LOCALBASE}/bin/bash". I'd probably choose
the former unless there's a good reason to ignore PATH.

-- 
You are receiving this mail because:
You are the assignee for the bug.