maintainer-feedback requested: [Bug 206545] mail/thunderbird: fix build with clang 3.8.0

[bugzilla-noreply at freebsd.org]

Dimitry Andric <dim at FreeBSD.org> has reassigned Bugzilla Automation
<bugzilla at FreeBSD.org>'s request for maintainer-feedback to gecko at FreeBSD.org:
Bug 206545: mail/thunderbird: fix build with clang 3.8.0
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206545



--- Description ---
Created attachment 166031
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=166031&action=edit
Remove superfluous (and ambiguous) forward declarations from MessageEvent.h

During the exp-run in bug 206074, it was found that mail/thunderbird gives
errors with a recent clang 3.8.0 snapshot [1]:

../../dist/include/mozilla/dom/MessageEvent.h:61:32: error: reference to
'MessagePort' is ambiguous
  void SetSource(mozilla::dom::MessagePort* aPort);
			       ^
../../dist/include/mozilla/dom/MessagePort.h:54:7: note: candidate found by
name lookup is 'mozilla::dom::MessagePort'
class MessagePort final : public MessagePortBase
      ^
../../dist/include/mozilla/dom/MessageEvent.h:18:7: note: candidate found by
name lookup is 'mozilla::dom::MessagePort'
class MessagePort;
      ^

Similar to bug 206333 (for www/libxul), this is caused by unneeded forward
declarations of class MessagePort, MessagePortBase and MessagePortList.  These
should be removed.

Obtained from:
https://github.com/jsonn/pkgsrc/blob/trunk/www/firefox38/patches/patch-dom_even
ts_MessageEvent.h

[1]
http://package18.nyi.freebsd.org/data/headamd64PR206074-default/2016-01-15_15h2
6m58s/logs/errors/thunderbird-38.5.0.log