[Bug 201273] multimedia/openh264 fails to build on armv6

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201273

--- Comment #1 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 158258
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=158258
armv6 fix

>--- Makefile	(revision 390884)
>+++ Makefile	(working copy)
>@@ -44,8 +44,12 @@
> 
> .include <bsd.port.options.mk>
> 
>+.if ${ARCH} == "armv6"
>+CFLAGS+= -no-integrated-as

What is this for? All *.S files are conditionalized by HAVE_NEON.
Not to mention the flag is Clang-specific, so would break GCC build.

>+.endif
>+
> .if ! ${PORT_OPTIONS:MDEBUG}
>-. if ${ARCH} == amd64 || ${ARCH} == arm || ${ARCH} == i386
>+. if ${ARCH} == amd64 || ${ARCH} == arm || ${ARCH} == armv6 || ${ARCH} == i386

My fault. nasm is only used on x86. arm and arm64 use cc(1).
I'll remove arm from there to avoid confusion.

> BUILD_DEPENDS+=	nasm:${PORTSDIR}/devel/nasm
> . endif
> .endif
>
>--- files/patch-build_arch.mk	(revision 0)
>+++ files/patch-build_arch.mk	(working copy)
>@@ -0,0 +1,10 @@
>+--- build/arch.mk.orig	2015-07-01 17:00:32 UTC
>++++ build/arch.mk
>+@@ -5,7 +5,6 @@ ifneq ($(filter-out arm64, $(filter arm%
>+ ifeq ($(USE_ASM), Yes)
>+ ASM_ARCH = arm
>+ ASMFLAGS += -I$(SRC_PATH)codec/common/arm/
>+-CFLAGS += -DHAVE_NEON

Does FreeBSD not support NEON at all or only on armv6? If the latter
try replacing

  ifneq ($(filter-out arm64, $(filter arm%, $(ARCH))),)

with

  ifneq ($(filter-out armv6 arm64, $(filter arm%, $(ARCH))),)

-- 
You are receiving this mail because:
You are the assignee for the bug.