[Bug 202165] www/firefox 40.0 fails to build with logging disabled

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202165

--- Comment #8 from Tomasz Sowa <bugsfreebsd at ttmath.org> ---
(In reply to rkoberman from comment #7)

Could you provide the exact url on which firefox crashes? I would like to test
it. I have compiled firefox with logging disabled:

/usr/ports/www/firefox# make showconfig
===> The following configuration options are available for firefox-40.0,1:
     CANBERRA=off: Sound theme alerts
     DBUS=on: D-Bus IPC system support
     DEBUG=off: Build with debugging support
     DTRACE=off: Build with DTrace probes
     GCONF=off: GConf configuration backend support
     GIO=off: Use GIO for file I/O
     GNOMEUI=off: libgnomeui support module
     GSTREAMER=on: Multimedia support via GStreamer
     LIBPROXY=off: Proxy support via libproxy
     LOGGING=off: Additional log messages
     OPTIMIZED_CFLAGS=on: Use extra compiler optimizations
     PGO=off: Use Profile-Guided Optimization
     PROFILE=off: Build with profiling support
     TEST=off: Build and/or run tests
====> Options available for the multi AUDIO: you have to choose at least one of
them
     ALSA=on: ALSA audio architecture support
     PULSEAUDIO=off: PulseAudio sound server support
====> Options available for the single TOOLKIT: you have to select exactly one
of them
     GTK2=on: GTK+ 2 GUI toolkit support
     GTK3=off: GTK+ 3 GUI toolkit support
===> Use 'make config' to modify these settings


with following patch:


--- work.orig/mozilla-release/layout/base/nsRefreshDriver.cpp    2015-08-07
00:39:40.000000000 +0200
+++ work/mozilla-release/layout/base/nsRefreshDriver.cpp    2015-08-08
23:21:48.577734000 +0200
@@ -25,6 +25,7 @@
 #include "WinUtils.h"
 #endif

+#include "nspr/prlog.h"
 #include "mozilla/ArrayUtils.h"
 #include "mozilla/AutoRestore.h"
 #include "nsHostObjectProtocolHandler.h"
--- work.orig/mozilla-release/layout/base/nsLayoutUtils.cpp    2015-08-07
00:39:40.000000000 +0200
+++ work/mozilla-release/layout/base/nsLayoutUtils.cpp    2015-08-08
23:18:57.235017000 +0200
@@ -4,6 +4,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

+#include "nspr/prlog.h"
 #include "nsLayoutUtils.h"

 #include "mozilla/ArrayUtils.h"
--- work.orig/mozilla-release/widget/nsPrintSettingsImpl.cpp    2015-08-07
00:39:46.000000000 +0200
+++ work/mozilla-release/widget/nsPrintSettingsImpl.cpp    2015-08-08
23:14:27.846498000 +0200
@@ -3,6 +3,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

+#include "nspr/prlog.h"
 #include "nsPrintSettingsImpl.h"
 #include "nsReadableUtils.h"
 #include "nsIPrintSession.h"
--- work.orig/mozilla-release/gfx/layers/Layers.h    2015-08-07
00:39:48.000000000 +0200
+++ work/mozilla-release/gfx/layers/Layers.h    2015-08-08 23:20:37.643774000
+0200
@@ -6,6 +6,7 @@
 #ifndef GFX_LAYERS_H
 #define GFX_LAYERS_H

+#include "nspr/prlog.h"
 #include <stdint.h>                     // for uint32_t, uint64_t, uint8_t
 #include <stdio.h>                      // for FILE
 #include <sys/types.h>                  // for int32_t, int64_t
--- work.orig/mozilla-release/gfx/layers/Layers.cpp    2015-08-07
00:39:48.000000000 +0200
+++ work/mozilla-release/gfx/layers/Layers.cpp    2015-08-08 23:19:52.524416000
+0200
@@ -5,6 +5,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

+#include "nspr/prlog.h"
 #include "Layers.h"
 #include <algorithm>                    // for max, min
 #include "apz/src/AsyncPanZoomController.h"
--- work.orig/mozilla-release/gfx/2d/Logging.h    2015-08-07 00:39:47.000000000
+0200
+++ work/mozilla-release/gfx/2d/Logging.h    2015-08-08 23:24:21.277642000
+0200
@@ -11,6 +11,8 @@
 #include <stdio.h>
 #include <vector>

+#include "nspr/prlog.h"
+
 #ifdef MOZ_LOGGING
 #include <prlog.h>
 #endif
--- work.orig/mozilla-release/dom/media/MediaDecoder.cpp    2015-08-07
00:39:34.000000000 +0200
+++ work/mozilla-release/dom/media/MediaDecoder.cpp    2015-08-08
23:35:27.261569000 +0200
@@ -52,6 +52,8 @@
 // avoid redefined macro in unified build
 #undef DECODER_LOG

+PRLogModuleInfo* gMediaDecoderLog;
+
 #ifdef PR_LOGGING
 PRLogModuleInfo* gMediaDecoderLog;
 #define DECODER_LOG(x, ...) \
@@ -121,6 +123,7 @@
 PRLogModuleInfo* gMediaPromiseLog;
 PRLogModuleInfo* gMediaTimerLog;

+  
 void
 MediaDecoder::InitStatics()
 {

-- 
You are receiving this mail because:
You are the assignee for the bug.