www/firefox (r315793, 20.0.1) does not compile

[Jan Beich]

Matthias Apitz <guru at unixarea.de> writes:

> El día Saturday, April 13, 2013 a las 01:13:46PM -0500, Jan Beich escribió:
>
>> Matthias Apitz <guru at unixarea.de> writes:
>> 
>> > # uname -a
>> > FreeBSD aurora.Sisis.de 10.0-CURRENT FreeBSD 10.0-CURRENT #0
>> > r235646: Sat May 19 15:52:36 CEST 2012
>> > guru at aurora.Sisis.de:/usr/obj/usr/src/sys/GENERIC i386
>> >
>> 
>> At that time jemalloc 3.0.0 was imported, expect regressions.
>> 
>> /head had recently imported clang 3.3 so www/firefox may have compile
>> and runtime regressions. Be prepared or add USE_GCC=yes to Makefile.local.
>>
>
> With gcc it gives the same error; and if I add to the source
> /usr/ports/www/firefox/work/mozilla-release/memory/mozalloc/mozalloc.cpp
> the following include (as the man page requests):
>
> #include <stdlib.h>             // for malloc, free
> #include <malloc_np.h>          // added by me

mozalloc.cpp uses malloc_usable_size() only if configure detects its
presence in libc or LIBS and malloc_np.h if it exists and is not buggy
i.e., simply including the header doesn't produce errors.

On /head firefox also uses the new jemalloc3 api in malloc_np.h to
implement jemalloc_stats and malloc_good_size() instead of overriding
the malloc() in libc like it does for /stable/[89].

>
> it gives other errors:
>
> ...
> gmake[3]: Entering directory
> `/usr/ports/www/firefox/work/mozilla-release/obj-i386-portbld-freebsd10.0/memory/mozalloc'
> g++46 -o mozalloc.o -c   -DMOZ_GLUE_IN_PROGRAM -DNO_NSPR_10_SUPPORT
> -I../../xpcom -I../../../memory/mozalloc -I. -I../../dist/include
> -I/usr/local/include/nspr -I/usr/local/include/nss
> -I/usr/local/include/nss/nss -I/usr/local/include -I/usr/local/include
> -fPIC -isystem/usr/local/include  -I/usr/local/include -Wall
> -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits
> -Wempty-body -Wno-ctor-dtor-privacy -Wno-overlength-strings
> -Wno-invalid-offsetof -Wno-variadic-macros -Wcast-align -O2 -pipe
> -Wl,-rpath=/usr/local/lib/gcc46 -fno-strict-aliasing
> -Wl,-rpath=/usr/local/lib/gcc46 -fno-exceptions -fno-strict-aliasing
> -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions
> -std=gnu++0x -pipe  -DNDEBUG -DTRIMMED -fno-omit-frame-pointer
> -isystem/usr/local/include  -I/usr/local/include -DMOZILLA_CLIENT
> -include ../../mozilla-config.h -MD -MF .deps/mozalloc.o.pp
> /usr/ports/www/firefox/work/mozilla-release/memory/mozalloc/mozalloc.cpp
> In file included from
> /usr/ports/www/firefox/work/mozilla-release/memory/mozalloc/mozalloc.cpp:19:0:
> /usr/include/malloc_np.h:59:19: error: expected '(' before 'nonnull'
> /usr/include/malloc_np.h:59:30: error: expected ')' before ';' token
> /usr/include/malloc_np.h:61:30: error: expected '(' before 'nonnull'
> /usr/include/malloc_np.h:61:41: error: expected ')' before ';' token
> /usr/include/malloc_np.h:63:19: error: expected '(' before 'nonnull'
> /usr/include/malloc_np.h:63:30: error: expected ')' before ';' token
> /usr/include/malloc_np.h:64:49: error: expected '(' before 'nonnull'
> /usr/include/malloc_np.h:64:60: error: expected ')' before ';' token
> gmake[3]: *** [mozalloc.o] Error 1
>
> And now? Thanks

http://svnweb.freebsd.org/changeset/base/235780

>
> 	matthias