Always-0 NFS statistics

[Ed Maste]

On Thu, 22 Oct 2020 at 21:46, Rick Macklem <rmacklem at uoguelph.ca> wrote:
>
> >nfsstat's name    kernel name
> >Retfailed         srv_errs
> >Faults            srvrpc_errs
> >Idem              srvcache_idemdonehits
> I believe these are left over from when the code was originally written
> for OpenBSD2.6, which did not have a separate kernel RPC, where the
> NFS code did the RPC calls.
>
> I suppose they should have been deleted from the FreeBSD port once
> it was incorporated into FreeBSD using the kernel RPC, but they were
> not.
>
> Revising the nfsstats structure yet again is a bother.
> I suppose you could modify nfsstats.c so that it never displays these
> fields. I doubt that would be considered a POLA violation.

Would it make sense to also rename them to int reserved_{1,2,3} to
make it clear in kernel that they're unused?