[Bug 234705] zpool initialize does not BIO_DELETE

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Jan 8 03:36:44 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234705

Warner Losh <imp at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |imp at FreeBSD.org

--- Comment #2 from Warner Losh <imp at FreeBSD.org> ---
These days, BIO_DELETE is almost always a win. Writing zeros is a big lose
often (though if the lower-layers implement a special WRITE ZEROS command,
there might be some cases where that's useful: we currently do not). I doubt
BOTH are ever anything but extra work. I would argue, however, that we should
think carefully here. The difference between DSM Deallocate and WRITE ZEROS +
Deallocate flag (for those nvme drives that support it) is very small (trimmed
blocks can return a variety of things depending: 0, ff or last written data)...

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-fs mailing list