[Bug 228750] panic on zfs mirror removal

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Oct 15 21:59:44 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228750

--- Comment #15 from commit-hook at freebsd.org ---
A commit references this bug:

Author: mav
Date: Mon Oct 15 21:59:24 UTC 2018
New revision: 339372
URL: https://svnweb.freebsd.org/changeset/base/339372

Log:
  Skip VDEV_IO_DONE stage only for ZIO_TYPE_FREE.

  Device removal code uses zio_vdev_child_io() with ZIO_TYPE_NULL parent,
  that never happened before.  It confused FreeBSD-specific TRIM code,
  which does not use VDEV_IO_DONE for logical ZIO_TYPE_FREE ZIOs.  As
  result of that stage being skipped device removal ZIOs leaked references
  and memory that supposed to be freed by VDEV_IO_DONE, making it stuck.

  It is a quick patch rather then a nice fix, but hopefully we'll be able
  to drop it all together when alternative TRIM implementation finally get
  landed.

  PR:           228750, 229007
  Discussed with:       allanjude, avg, smh
  Approved by:  re (delphij)
  MFC after:    5 days
  Sponsored by: iXsystems, Inc.

Changes:
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-fs mailing list