[Bug 217879] [ufs] couple of cppcheck findings

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Mar 19 14:19:23 UTC 2017


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217879

Konstantin Belousov <kib at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |Not A Bug
             Status|New                         |Closed

--- Comment #1 from Konstantin Belousov <kib at FreeBSD.org> ---
The report is false, and patch is wrong.

The code tries to find a first element of the specific type (D_JSEGDEP in case
of jwork_insert, D_ALLOCDIRECT for setup_newdir).  This is done by the
LIST_FOREACH() loop.  If no element was found, i.e. the condition wk == NULL
after the loop, then something other is done.

The patch breaks the logic.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-fs mailing list