kern/157365: commit references a PR

[dfilter service]

The following reply was made to PR kern/157365; it has been noted by GNATS.

From: dfilter at FreeBSD.ORG (dfilter service)
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: kern/157365: commit references a PR
Date: Sun, 29 May 2011 21:14:07 +0000 (UTC)

 Author: rmacklem
 Date: Sun May 29 21:13:53 2011
 New Revision: 222466
 URL: http://svn.freebsd.org/changeset/base/222466
 
 Log:
   Modify the umount(8) command so that it doesn't do
   a sync(2) syscall before unmount(2) for the "-f" case.
   This avoids a forced dismount from getting stuck for
   an NFS mountpoint in sync() when the server is not
   responsive. With this commit, forced dismounts should
   normally work for the NFS clients, but can take up to
   about 1minute to complete.
   
   PR:		kern/157365
   Reviewed by:	kib
   MFC after:	2 weeks
 
 Modified:
   head/sbin/umount/umount.c
 
 Modified: head/sbin/umount/umount.c
 ==============================================================================
 --- head/sbin/umount/umount.c	Sun May 29 21:03:40 2011	(r222465)
 +++ head/sbin/umount/umount.c	Sun May 29 21:13:53 2011	(r222466)
 @@ -90,9 +90,6 @@ main(int argc, char *argv[])
  	struct statfs *mntbuf, *sfs;
  	struct addrinfo hints;
  
 -	/* Start disks transferring immediately. */
 -	sync();
 -
  	all = errs = 0;
  	while ((ch = getopt(argc, argv, "AaF:fh:t:v")) != -1)
  		switch (ch) {
 @@ -127,6 +124,10 @@ main(int argc, char *argv[])
  	argc -= optind;
  	argv += optind;
  
 +	/* Start disks transferring immediately. */
 +	if ((fflag & MNT_FORCE) == 0)
 +		sync();
 +
  	if ((argc == 0 && !all) || (argc != 0 && all))
  		usage();
  
 _______________________________________________
 svn-src-all at freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe at freebsd.org"