Review request for NFS readdirplus change.
Rick Macklem
rmacklem at uoguelph.ca
Mon Sep 14 16:16:14 UTC 2009
On Mon, 14 Sep 2009, John Baldwin wrote:
> On Sunday 13 September 2009 4:23:50 pm Pawel Jakub Dawidek wrote:
>> Hi.
>>
>> I'm looking for a review of the following patch:
>>
>> http://people.freebsd.org/~pjd/patches/nfs_serv.c.3.patch
>>
[good stuff snipped]
>
> I don't think you need the trailing '\' before a split expression when
> building cn_flags. Other than that I think it looks ok from what I can see
> (but I am far less familiar with the NFS server than the NFS client). Also,
> you might want to patch the new NFS server as well as the old one (or ask
> Rick about the new one).
>
Looks fine to me, too (although I'm not particularily familiar with the
flags for VOP_LOOKUP()). I can do a similar change to the experimental
server once it goes in.
rick
More information about the freebsd-fs
mailing list