call for help on TMPFS

[Howard Su]

On 5/27/07, Pawel Jakub Dawidek <pjd at freebsd.org> wrote:
> On Sat, May 26, 2007 at 12:06:14AM +0800, Howard Su wrote:
> I think you are missing some cases in lookup where you should add
> SAVENAME flag. I'd start from adding this (or similar) assertions:
>
>         KASSERT((ap->a_cnp->cn_flags & SAVENAME), ("No SAVENAME"));
>
> to the following functions:
>
>         tmpfs_create()
>         tmpfs_remove()
>         tmpfs_mkdir()
>         tmpfs_rmdir()
>         tmpfs_rename() (assert both: fcnp and tcnp)
>         tmpfs_symlink()
>         tmpfs_link()
Thank you very much. You are right. I just fixed this long standing panic.

PS: I noticed that kernel option DIAGNOSTIC will clean ap->a_cnp with
NULL if you don't give SAVENAME. So I enable DIAGNOSTIC instead of
adding asserts.

-- 
-Howard